Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
Menu
Open sidebar
Jenny Ryan
ouinet
Commits
164972f9
Commit
164972f9
authored
Apr 14, 2020
by
Ivan Vilata-i-Balaguer
Browse files
Note on fixed line length in v1 HTTP store signature files.
parent
6bcd66b8
Changes
1
Hide whitespace changes
Inline
Side-by-side
src/cache/http_store.cpp
View file @
164972f9
...
...
@@ -718,6 +718,12 @@ private:
get_last_sig_offset
(
Cancel
cancel
,
asio
::
yield_context
yield
)
{
// TODO: seek to avoid parsing the whole file
// TODO: This would be easier if lines had a fixed size,
// e.g. by padding the offset to the length of `max(size_t)`.
// A way to cut the overhead would be to use `max(size_t/block_length)`,
// with a different fixed line length for each stored entry,
// but if overhead is an issue, a binary format should be used instead.
boost
::
optional
<
std
::
size_t
>
off
;
while
(
true
)
{
sys
::
error_code
ec
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment